Re: Increasing skb->mark size
From: David Miller <davem@davemloft.net>
Date: 2015-11-30 01:58:58
From: Lorenzo Colitti <redacted> Date: Sun, 29 Nov 2015 17:37:11 +0900
On Wed, Nov 25, 2015 at 5:32 AM, Matt Bennett [off-list ref] wrote:quoted
I'm emailing this list for feedback on the feasibility of increasing skb->mark or adding a new field for marking. Perhaps this extension could be done under a new CONFIG option.64-bit marks (both skb->mark and sk->sk_mark) would be useful for hosts doing complex policy routing as well. Current Android releases use 20 of the 32 bits. If the mark were 64 bits, we could put the UID in it, and stop using ip rules to implement per-UID routing.
If you guys, really anyone, can find a way to remove some other 32-bit item from sk_buff, you can expand skb->mark to 64-bits. But otherwise, I'm going to be strongly against it. sk_buff is already enormous and larger than it should be. So I'm going to resist any change that makes it even larger. Thanks.