Thread (6 messages) 6 messages, 3 authors, 2015-11-30

RE: [PATCH 1/2] net: fsl: Don't use NO_IRQ to check return value of irq_of_parse_and_map()

From: Manoil Claudiu <hidden>
Date: 2015-11-26 15:18:32

-----Original Message-----
From: Mark Brown [mailto:broonie@kernel.org]
Sent: Thursday, November 26, 2015 2:00 PM
To: Manoil Claudiu-B08782 <redacted>; Xie Shaohui-
B21989 [off-list ref]; David S . Miller
[off-list ref]
Cc: netdev@vger.kernel.org; Mark Brown <broonie@kernel.org>
Subject: [PATCH 1/2] net: fsl: Don't use NO_IRQ to check return value of
irq_of_parse_and_map()

This driver can be built on arm64 but relies on NO_IRQ to check the return
value of irq_of_parse_and_map() which fails to build on arm64 because the
architecture does not provide a NO_IRQ. Fix this to correctly check the
return value of irq_of_parse_and_map().

Even on ARM systems where the driver was previously used the check was
broken since on ARM NO_IRQ is -1 but irq_of_parse_and_map() returns 0 on
error.

Signed-off-by: Mark Brown <broonie@kernel.org>
Ack.
Suggesting the v2 patch below instead, adding a missing fix:
http://patchwork.ozlabs.org/patch/549126/
("[net,v2] gianfar: Don't use NO_IRQ to check return value of irq_of_parse_and_map()")

Thanks,
Claudiu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help