Re: [PATCH] can: Use correct type in sizeof() in nla_put()
From: Marek Vasut <marex@denx.de>
Date: 2015-10-30 14:01:28
Also in:
linux-can
From: Marek Vasut <marex@denx.de>
Date: 2015-10-30 14:01:28
Also in:
linux-can
On Friday, October 30, 2015 at 02:40:26 PM, Marc Kleine-Budde wrote:
On 10/30/2015 01:48 PM, Marek Vasut wrote:quoted
The sizeof() is invoked on an incorrect variable, likely due to some copy-paste error, and this might result in memory corruption. Fix this. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Wolfgang Grandegger <redacted> Cc: Marc Kleine-Budde <mkl@pengutronix.de> Cc: netdev@vger.kernel.orgApplies to can and added stable on Cc.
Are you absolutelly positive this doesn't break kernel ABI please ? I am a little worried there, since the size of can_clock and can_ctrlmode structures differ. Best regards, Marek Vasut