Re: [PATCH 3.19 and earlier] fib_rules: Fix dump_rules() not to exit early

On Mon, Oct 05, 2015 at 10:29:28AM -0700, Roland Dreier wrote:

From: Roland Dreier <redacted>

Backports of 41fc014332d9 ("fib_rules: fix fib rule dumps across
multiple skbs") introduced a regression in "ip rule show" - it ends up
dumping the first rule over and over and never exiting, because 3.19
and earlier are missing commit 053c095a82cf ("netlink: make
nlmsg_end() and genlmsg_end() void"), so fib_nl_fill_rule() ends up
returning skb->len (i.e. > 0) in the success case.

Fix this by checking the return code for < 0 instead of != 0.

Signed-off-by: Roland Dreier <redacted>
---
Hi, this is needed for all stable trees earlier than 4.0 that have
picked up 41fc014332d9; so far looks like at least 3.10.y and 3.14.y
have made such releases.

Thanks for this, now applied to 3.10 and 3.14-stable trees.

greg k-h