Re: [RFC PATCH v3 1/5] net: dsa: allow switch drivers to cleanup their resources
From: Andrew Lunn <andrew@lunn.ch>
Date: 2015-10-29 14:51:06
Also in:
lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2015-10-29 14:51:06
Also in:
lkml
On Thu, Oct 29, 2015 at 03:45:24PM +0100, Neil Armstrong wrote:
Some switch drivers might request interrupts, remap register ranges, allow such drivers to implement a "remove" callback doing just that. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Neil Armstrong <redacted> --- include/net/dsa.h | 1 + net/dsa/dsa.c | 4 ++++ 2 files changed, 5 insertions(+)diff --git a/include/net/dsa.h b/include/net/dsa.h index 98ccbde..0e1502c 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h@@ -212,6 +212,7 @@ struct dsa_switch_driver { */ char *(*probe)(struct device *host_dev, int sw_addr); int (*setup)(struct dsa_switch *ds); + void (*remove)(struct dsa_switch *ds); int (*set_addr)(struct dsa_switch *ds, u8 *addr); u32 (*get_phy_flags)(struct dsa_switch *ds, int port);diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index 1eba07f..f462fc5 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c@@ -459,6 +459,10 @@ static void dsa_switch_destroy(struct dsa_switch *ds) } mdiobus_unregister(ds->slave_mii_bus); + + /* Leave a chance to the driver to cleanup */ + if (ds->drv->remove) + ds->drv->remove(ds); }
https://lkml.org/lkml/2015/10/28/532 ??? Andrew