Thread (5 messages) flat view 5 messages, 3 authors, 2015-10-28

Re: [PATCH] vhost: fix performance on LE hosts

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2015-10-27 15:52:40
Also in: kvm, lkml, virtualization

On Tue, Oct 27, 2015 at 06:32:55AM -0700, David Miller wrote:
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Tue, 27 Oct 2015 11:37:39 +0200
quoted
commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian
support for legacy devices") introduced a minor regression: even with
cross-endian disabled, and even on LE host, vhost_is_little_endian is
checking is_le flag so there's always a branch.

To fix, simply check virtio_legacy_is_little_endian first.

Cc: Greg Kurz <redacted>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Michael, do you want me to take this via the 'net' tree?
Sure - especially since it looks like I have nothing else for this merge
window (working on fixing shutdown races, but it's slow going).  Thanks
a lot!

-- 
MST
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help