Thread (13 messages) flat view 13 messages, 5 authors, 2015-10-27

Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

From: Alexei Starovoitov <hidden>
Date: 2015-10-23 14:42:26
Also in: lkml

On 10/23/15 5:03 AM, Peter Zijlstra wrote:
So the bpf_perf_event_read() returns the count value, does this not also
mean that returning -EINVAL here is also 'wrong'?

I mean, sure an actual count value that high is unlikely, but its still
a broken interface.
Agree. that's not pretty interface. I wish I looked at it more carefully
when it was introduced. Now it's too late to change.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help