On Thu, Oct 08, 2015 at 10:07:44AM -0700, Bjorn Andersson wrote:

On Sat 03 Oct 09:55 PDT 2015, Marcel Holtmann wrote:

quoted

Hi Bjorn,

[..]

quoted

quoted

quoted

Especially the kbuild test robot complained loudly.

Sorry, I forgot to mention in the patch that the patch depends on the
qcom_smd_id patch - that's available in linux-next. I will take another
look, but I think that was the cause of all the issues.

which means, I can only merge this driver when this other patch has
hit net-next tree. Unless I take the qcom_smd_id through
bluetooth-next tree which doesn't look like a good idea.

I was going to suggest that we just wait for -rc1, but the new additions
to SMD adds a bunch of new items on the dependency list.

Perhaps once we agree we can get your Ack and have Andy pull it through
the qcom-soc tree together with the SMD patches?

This is fine by me.

quoted

quoted

quoted

quoted

obj-$(CONFIG_BT_INTEL)              += btintel.o
obj-$(CONFIG_BT_ATH3K)              += ath3k.o

diff --git a/drivers/bluetooth/hci_smd.c b/drivers/bluetooth/hci_smd.c

[..]

quoted

quoted

+#include <net/bluetooth/hci.h>

The hci.h include is not needed. If you do, then you are doing
something fishy.

<snip>

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project