Thread (7 messages) flat view 7 messages, 4 authors, 2015-10-08

Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

From: Jiri Pirko <jiri@resnulli.us>
Date: 2015-10-07 06:43:35
Also in: linux-arm-kernel, lkml

Tue, Oct 06, 2015 at 11:47:44PM CEST, arnd@arndb.de wrote:
The recently added mlxsw driver produces warnings in ARM
allmodconfig:

drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count >= width of type [-Wshift-count-overflow]
linux/byteorder/big_endian.h:38:51: note: in definition of macro '__cpu_to_be32'
drivers/net/ethernet/mellanox/mlxsw/pci.c:76:2: note: in expansion of macro 'iowrite32be'

This changes the type of the local variable to u64, which gets rid of the
warning and seems nicer than adding #ifdefs.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: eda6500a987a "mlxsw: Add PCI bus implementation"
Acked-by: Jiri Pirko <redacted>

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help