Re: [PATCH v2 05/14] RDS: defer the over_batch work to send worker
From: David Miller <hidden>
Date: 2015-10-05 10:15:11
Also in:
linux-rdma, lkml
From: Santosh Shilimkar <redacted> Date: Wed, 30 Sep 2015 13:24:24 -0400
quoted hunk ↗ jump to hunk
@@ -423,7 +423,9 @@ over_batch: !list_empty(&conn->c_send_queue)) && send_gen == conn->c_send_gen) { rds_stats_inc(s_send_lock_queue_raced); - goto restart; + if (batch_count < 1024) + goto restart; + queue_delayed_work(rds_wq, &conn->c_send_w, 1);
Sorry, you can't just use a magic number like this. You have to describe, in detail, exactly how this value was choosen, derived, and tested to be effeective and in exactly what environment those tests were done. You must also use a mnenomic for this value rather than a raw magic constant. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html