Re: [PATCH] ceph:Remove unused goto labels in decode crush map functions
From: Ilya Dryomov <idryomov@gmail.com>
Date: 2015-10-03 05:44:06
Also in:
ceph-devel, lkml
On Fri, Oct 2, 2015 at 9:48 PM, Nicholas Krause [off-list ref] wrote:
quoted hunk
This removes unused goto labels in decode crush map functions related to error paths due to them never being used on any error path for these particular functions in the file, osdmap.c. Signed-off-by: Nicholas Krause <redacted> --- net/ceph/osdmap.c | 10 ---------- 1 file changed, 10 deletions(-)diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c index 7d8f581..2f8e41c 100644 --- a/net/ceph/osdmap.c +++ b/net/ceph/osdmap.c@@ -59,8 +59,6 @@ static int crush_decode_uniform_bucket(void **p, void *end, ceph_decode_need(p, end, (1+b->h.size) * sizeof(u32), bad);
^^^
b->item_weight = ceph_decode_32(p);
return 0;
-bad:^^^
- return -EINVAL; }
I realize that these macros are sneaky, but you should at least
compile-test your patches before you send them out.
Thanks,
Ilya