Re: [PATCH] sh_eth: move inline functions to the header file
From: Sergei Shtylyov <hidden>
Date: 2015-10-30 23:09:15
Also in:
linux-sh
Hello. On 04/07/2015 10:33 PM, David Miller wrote:
quoted
quoted
quoted
The explicitly inline functions belong to the header files, so move cpu_to_edmac() and edmac_to_cpu() into the driver header.quoted
quoted
While at it, make these functions return 'u32' instead of '__u32'.quoted
quoted
Signed-off-by: Sergei Shtylyov <redacted>quoted
Then... ummm... remove the inline keyword?quoted
If it's not used anywhere else, that's the thing to do.Results in more code, as I noted in the patch posting that you skipped when replying. At least with gcc 4.7.That's a compiler bug.
Even worse, these functions support the BE mode which never was used and
never worked correctly. I'll just try to remove them altogether.
MBR, Sergei