Thread (3 messages) flat view 3 messages, 2 authors, 2015-10-26

Re: [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

From: Carol Soto <hidden>
Date: 2015-10-26 18:27:27


On 10/26/2015 12:02 PM, Or Gerlitz wrote:
On Mon, Oct 26, 2015 at 5:15 PM,  [off-list ref] wrote:
quoted
From: Carol L Soto <redacted>

If the caps.eqe_size is bigger than the struct mlx4_eqe then there
is a potential for corrupting data at the master context. We can see
the message "Master failed to generate an EQE for slave: X" when the
event_eqe array wraps and we can see potential oops at the function
mlx4_GEN_EQE. Also correct a memset of cmd_eqe to use the sizeof
mlx4_eqe instead of eqe_size.

Fixes: 08ff32352d6f ('mlx4: 64-byte CQE/EQE support')
Signed-off-by: Carol L Soto <redacted>
Thanks Carol, I'd like to review this a bit more tomorrow and will
send it with another fix/es to net
Sure thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help