Re: [PATCH net-next 06/15] ipv4: Merge ip_local_out and ip_local_out_sk
From: Nicolas Dichtel <hidden>
Date: 2015-10-07 14:48:59
Also in:
lvs-devel, netfilter-devel
Le 06/10/2015 20:53, Eric W. Biederman a écrit :
It is confusing and silly hiding a paramater so modify all of the callers to pass in the appropriate socket or skb->sk if no socket is known. Signed-off-by: "Eric W. Biederman" <redacted> ---
[snip]
quoted hunk ↗ jump to hunk
@@ -456,7 +456,7 @@ packet_routed: skb->priority = sk->sk_priority; skb->mark = sk->sk_mark; - res = ip_local_out(skb); + res = ip_local_out(sk, skb);
As stated in the comment at the top of this function (ip_queue_xmit()), skb->sk
can be different from sk. See also commit b0270e91014d ("ipv4: add a sock
pointer to ip_queue_xmit()").
Not sure if this change is right.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html