Thread (4 messages) flat view 4 messages, 3 authors, 2015-10-06

Re: [PATCH] ipvs: Remove unused net variable from ip_vs_out

From: Julian Anastasov <ja@ssi.bg>
Date: 2015-10-06 06:35:54
Also in: lvs-devel, netfilter-devel

	Hello,

On Fri, 2 Oct 2015, Simon Horman wrote:
quoted hunk ↗ jump to hunk
Since 6f2bcea9917d ("ipvs: Pass ipvs into ip_vs_in_icmp and ip_vs_in_icmp_v6")
the net net variable in ip_vs_out() appears to be unused so remove it.

Signed-off-by: Simon Horman <horms@verge.net.au>
---
 net/netfilter/ipvs/ip_vs_core.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
index d08df435c2aa..72b6a44ea9de 100644
--- a/net/netfilter/ipvs/ip_vs_core.c
+++ b/net/netfilter/ipvs/ip_vs_core.c
@@ -1172,7 +1172,6 @@ drop:
 static unsigned int
 ip_vs_out(struct netns_ipvs *ipvs, unsigned int hooknum, struct sk_buff *skb, int af)
 {
-	struct net *net = ipvs->net;
	So, this line should be moved into the block
where the var is used?

Regards

--
Julian Anastasov [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help