Thread (2 messages) 2 messages, 2 authors, 2015-10-03

Re: [PATCH net-next] tcp/dccp: add SLAB_DESTROY_BY_RCU flag for request sockets

From: David Miller <davem@davemloft.net>
Date: 2015-10-03 20:10:28

From: Eric Dumazet <redacted>
Date: Sat, 03 Oct 2015 06:27:28 -0700
From: Eric Dumazet <redacted>

Before letting request sockets being put in TCP/DCCP regular
ehash table, we need to add either :

- SLAB_DESTROY_BY_RCU flag to their kmem_cache
- add RCU grace period before freeing them.

Since we carefully respected the SLAB_DESTROY_BY_RCU protocol
like ESTABLISH and TIMEWAIT sockets, use it here.

req_prot_init() being only used by TCP and DCCP, I did not add
a new slab_flags into their rsk_prot, but reuse prot->slab_flags

Since all reqsk_alloc() users are correctly dealing with a failure,
add the __GFP_NOWARN flag to avoid traces under pressure.

Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
Signed-off-by: Eric Dumazet <redacted>
Applied, thanks Eric.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help