Re: [patch net-next] switchdev: bring back switchdev_obj and use it as a generic object param
From: Scott Feldman <hidden>
Date: 2015-10-01 03:45:15
On Wed, Sep 30, 2015 at 9:00 AM, Jiri Pirko [off-list ref] wrote:
From: Jiri Pirko <redacted> Replace "void *obj" with a generic structure. Introduce couple of helpers along that. Signed-off-by: Jiri Pirko <redacted>
Looks good to me, except for the macro/enum collision Vivien pointed out. Vivien's suggestion to use SWITCHDEV_OBJ_ID_xxx for ID enums would work. Actually, id should be moved back into switchdev_obj, otherwise that info is lost in dump callbacks. Could have a common callback that switches on id, for id specific work. I'll submit a patch to move id back into obj if Jiri doesn't add it to this one.