Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes
From: Arnd Bergmann <hidden>
Date: 2015-09-14 15:41:32
Also in:
alsa-devel, linux-acpi, linux-bluetooth, linux-iommu, linux-mm, linux-scsi
On Monday 14 September 2015 09:21:54 Viresh Kumar wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c index b4c216bab22b..bea8e425a8de 100644 --- a/drivers/acpi/ec_sys.c +++ b/drivers/acpi/ec_sys.c@@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe)) goto error; if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, - (u32 *)&first_ec->global_lock)) + &first_ec->global_lock)) goto error; if (write_support)
This one might need a separate patch that can be backported to stable, as the original code is already broken on big-endian 64-bit machines: global_lock is 'unsigned long'. Arnd