Re: [RFC PATCH 1/3] net: introduce kfree_skb_bulk() user of kmem_cache_free_bulk()
From: David Miller <davem@davemloft.net>
Date: 2015-09-08 21:01:13
Also in:
linux-mm
From: Jesper Dangaard Brouer <redacted> Date: Fri, 04 Sep 2015 19:00:53 +0200
+/**
+ * kfree_skb_bulk - bulk free SKBs when refcnt allows to
+ * @skbs: array of SKBs to free
+ * @size: number of SKBs in array
+ *
+ * If SKB refcnt allows for free, then release any auxiliary data
+ * and then bulk free SKBs to the SLAB allocator.
+ *
+ * Note that interrupts must be enabled when calling this function.
+ */
+void kfree_skb_bulk(struct sk_buff **skbs, unsigned int size)
+{
+ int i;
+ size_t cnt = 0;
+
+ for (i = 0; i < size; i++) {
+ struct sk_buff *skb = skbs[i];
+
+ if (!skb_dec_and_test(skb))
+ continue; /* skip skb, not ready to free */
+
+ /* Construct an array of SKBs, ready to be free'ed and
+ * cleanup all auxiliary, before bulk free to SLAB.
+ * For now, only handle non-cloned SKBs, related to
+ * SLAB skbuff_head_cache
+ */
+ if (skb->fclone == SKB_FCLONE_UNAVAILABLE) {
+ skb_release_all(skb);
+ skbs[cnt++] = skb;
+ } else {
+ /* SKB was a clone, don't handle this case */
+ __kfree_skb(skb);
+ }
+ }
+ if (likely(cnt)) {
+ kmem_cache_free_bulk(skbuff_head_cache, cnt, (void **) skbs);
+ }
+}You're going to have to do a trace_kfree_skb() or trace_consume_skb() for these things. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>