Thread (3 messages) 3 messages, 3 authors, 2015-09-29

Re: [PATCH v2 1/1] net sysfs: Print link speed as signed integer

From: Jeremy Harris <hidden>
Date: 2015-09-29 15:14:08
Also in: lkml

On 28/09/15 14:05, Alexander Stein wrote:
Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link.
Documentation/ABI/testing/sysfs-class-net does not state if this shall be
signed or unsigned.
Also remove the now unused variable fmt_udec.
[...]
-			ret = sprintf(buf, fmt_udec, ethtool_cmd_speed(&cmd));
+			ret = sprintf(buf, fmt_dec, ethtool_cmd_speed(&cmd));
If we print anything numeric, why is zero not appropriate
(which would still be unsigned)?
-- 
Cheers,
     Jeremy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help