Thread (1 message) 1 message, 1 author, 2015-09-22

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: 2015-09-22 19:33:25
Also in: lkml

David Miller [off-list ref] writes:
From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: Fri, 18 Sep 2015 18:36:56 +0200
quoted
Which brings me to wonder which is the more correct :
 (a) replace to reproduce the same calculation
     Previously mtt was compared to a difference of 76ns steps (as 307ns / 4 =
     76ns):
     while ((sched_clock() - si->last_clk) * 76 < mtt)

 (b) change the calculation assuming mtt is in microseconds :
     while ((sched_clock() - si->last_clk) * 1000 < mtt)

I have no IRDA protocol knowledge so unless someone points me to the correct
calculation I'll try my luck with (b).
"a" would be "safer" and less likely to break anything, although as
you say "b" might be more correct.
Indeed.

Well, let me try (b) then. I'll add in the commit message the timings change,
and if anybody complains a regression pops out, I'll provide a patch to fallback
to (a).

Cheers.

-- 
Robert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help