RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

-----Original Message-----
From: Sudeep Holla [mailto:sudeep.holla@arm.com]
Sent: Monday, September 21, 2015 6:47 PM
To: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org
Cc: Sudeep Holla <redacted>; Thomas Gleixner
[off-list ref]; Rafael J. Wysocki [off-list ref]; David S. Miller
[off-list ref]; Manoil Claudiu-B08782
[off-list ref]; Kevin Hao [off-list ref];
netdev@vger.kernel.org
Subject: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND
flag

The device is set as wakeup capable using proper wakeup API but the
driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source
which is incorrect.

This patch removes the use of IRQF_NO_SUSPEND flags replacing it with
enable_irq_wake instead.

What would be the purpose of IRQF_NO_SUSPEND flag then?  The flag is a
friendlier API compared to calling enable_irq_wake().  For older kernels,
on PPC architectures, the flag did the job.  When did this change? Since
when using IRQF_NO_SUSPEND is a "misuse"?

Thanks,
Claudiu