Re: [RFC v3 net-next 09/10] qed: Add statistics support

Hi Manish,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: microblaze-allmodconfig (attached as .config)
reproduce:
  wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
  chmod +x ~/bin/make.cross
  git checkout fddd56febc638207706ef56cd993cbc73b59544e
  # save the attached .config to linux build tree
  make.cross ARCH=microblaze 

All warnings (new ones prefixed by >>):

   In file included from drivers/net/ethernet/qlogic/qed/qed_dev.c:21:0:
   include/linux/qed/qed_chain.h: In function 'qed_chain_init':
   include/linux/qed/qed_chain.h:420:4: warning: right shift count >= width of type
       p_next->next_phys.hi = DMA_HI_LE(p_phys_addr);
       ^
   include/linux/qed/qed_chain.h:420:4: warning: right shift count >= width of type
   include/linux/qed/qed_chain.h:420:4: warning: right shift count >= width of type
   include/linux/qed/qed_chain.h:420:4: warning: right shift count >= width of type
   include/linux/qed/qed_chain.h:420:4: warning: right shift count >= width of type
   include/linux/qed/qed_chain.h:420:4: warning: right shift count >= width of type
   include/linux/qed/qed_chain.h:436:3: warning: right shift count >= width of type
      p_next->next_phys.hi = DMA_HI_LE(p_chain->p_phys_addr);
      ^
   include/linux/qed/qed_chain.h:436:3: warning: right shift count >= width of type
   include/linux/qed/qed_chain.h:436:3: warning: right shift count >= width of type
   include/linux/qed/qed_chain.h:436:3: warning: right shift count >= width of type
   include/linux/qed/qed_chain.h:436:3: warning: right shift count >= width of type
   include/linux/qed/qed_chain.h:436:3: warning: right shift count >= width of type
   drivers/net/ethernet/qlogic/qed/qed_dev.c: In function '__qed_get_vport_stats':

quoted

drivers/net/ethernet/qlogic/qed/qed_dev.c:1679:1: warning: the frame size of 1096 bytes is larger than 1024 bytes [-Wframe-larger-than=]

    }
    ^

vim +1679 drivers/net/ethernet/qlogic/qed/qed_dev.c

  1663			stats->rx_mac_bytes	     += port_stats.pmm.rbyte;
  1664			stats->rx_mac_uc_packets	+= port_stats.pmm.rxuca;
  1665			stats->rx_mac_mc_packets	+= port_stats.pmm.rxmca;
  1666			stats->rx_mac_bc_packets	+= port_stats.pmm.rxbca;
  1667			stats->rx_mac_frames_ok	 += port_stats.pmm.rxpok;
  1668			stats->tx_mac_bytes	     += port_stats.pmm.tbyte;
  1669			stats->tx_mac_uc_packets	+= port_stats.pmm.txuca;
  1670			stats->tx_mac_mc_packets	+= port_stats.pmm.txmca;
  1671			stats->tx_mac_bc_packets	+= port_stats.pmm.txbca;
  1672			stats->tx_mac_ctrl_frames       += port_stats.pmm.txcf;
  1673	
  1674			for (j = 0; j < 8; j++) {
  1675				stats->brb_truncates += port_stats.brb.brb_truncate[j];
  1676				stats->brb_discards += port_stats.brb.brb_discard[j];
  1677			}
  1678		}

1679	}

  1680	
  1681	void qed_get_vport_stats(struct qed_dev *cdev,
  1682				 struct qed_eth_stats *stats)
  1683	{
  1684		u32 i;
  1685	
  1686		if (!cdev) {
  1687			memset(stats, 0, sizeof(*stats));

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation