Re: [PATCH] net/mlx4: Handle return codes in mlx4_qp_attach_common
From: David Miller <davem@davemloft.net>
Date: 2015-09-29 05:26:43
From: Robb Manes <redacted> Date: Fri, 25 Sep 2015 10:39:21 -0400
quoted hunk ↗ jump to hunk
@@ -1184,10 +1184,11 @@ out: if (prot == MLX4_PROT_ETH) { /* manage the steering entry for promisc mode */ if (new_entry) - new_steering_entry(dev, port, steer, index, qp->qpn); + err = new_steering_entry(dev, port, steer, + index, qp->qpn); else - existing_steering_entry(dev, port, steer, - index, qp->qpn); + err = existing_steering_entry(dev, port, steer, + index, qp->qpn);
Please indent this properly. When a function call spans multiple lines, the second and subsequent lines must start precisely at the first column after the openning parenthesis of the first line. You must use the appropriate number of TAB then SPACE characters necessary to achieve this. Thanks.