Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode
From: Aaron Conole <hidden>
Date: 2015-09-27 01:44:48
Greetings. Tolga Ceylan [off-list ref] writes:
+#define SO_REUSEPORT_LISTEN_OFF 51 +
For all of these, I think the space should be tab.
unsigned char skc_reuseport:1; + unsigned char skc_reuseport_listen_off:1; unsigned char skc_ipv6only:1;
The spacing here is wrong.
quoted hunk ↗ jump to hunk
@@ -224,10 +224,13 @@ begin: phash = inet_ehashfn(net, daddr, hnum, saddr, sport); matches = 1; + if (sk->sk_reuseport_listen_off) + result = NULL;
I am concerned here. I think you need to reset hiscore and matches as well, not just result.