Thread (9 messages) 9 messages, 2 authors, 2015-09-29

Re: [PATCH v3 2/2] [net] af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag

From: Aaron Conole <hidden>
Date: 2015-09-25 13:25:19

Thanks for your time and the review.

David Miller [off-list ref] writes:
From: Aaron Conole <redacted>
Date: Mon, 21 Sep 2015 20:27:02 -0400
quoted
+			goto unlock;
Sorry, I don't want to see goto's from one loop into a completely
different one.
I think you misread. This goto does not do that; it goes from the else 
side of one if block, into a different if block within the same do/while
pair. I assumed this was okay, because in 
commit:b48732e4a48d80ed4a14812f0bab09560846514e the same type of goto
unlock jump is used. Since that commit was accepted 4 months ago, I
figured the style hadn't changed. 

Would you rather see:
+			unix_state_unlock(sk);
+			break;
The XXX comment is probably not appropriate either.
Agreed, any v4 post will not include it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help