RE: [RFC v2 net-next 05/10] qede: Add basic network device support

quoted

quoted

quoted

+struct qede_rx_queue {
+	__le16			*hw_cons_ptr;

The __ variants of constants should be reserved for use in user
visible API's

Really? If so, this needs to be fixed not only here but in lots of
places in the series [e.g., entire HW HSI uses __le variants instead of le].
But why is it so? I.e., I understand that __le16 is defined in the
uapi directory and thus accessible to users, but why the distinction?

Because it shows whether the type is something exposed to userspace or not.

If there are places where this is done incorrectly in the tree, it is not a legitimate
reason for you to do so as well.

Obviously.
We'll fix all of those for next version.