Re: [PATCH net-next] ipv6 Use get_hash_from_flowi6 for rt6 hash

On Wed, Sep 23, 2015 at 2:57 PM, David Miller [off-list ref] wrote:

From: David Miller <davem@davemloft.net>
Date: Wed, 23 Sep 2015 14:21:38 -0700 (PDT)

quoted

From: Tom Herbert <redacted>
Date: Wed, 23 Sep 2015 14:13:35 -0700

quoted

In rt6_info_hash_nhsfn replace the custom hashing over flowi6 that is
using xor with a call to common function get_hash_from_flowi6.

Signed-off-by: Tom Herbert <redacted>

Applied, thanks.

Tom, I just so happened to look over the call paths that lead to this
function and the flowi6 ports aren't filled in much of the time.

I know your patch doesn't change things one way or the other in this
area, but I thought I'd bring it up nonetheless.

Yeah, I noticed  there's still a little work to do here. On input put
we should be passing in skb to use skb->hash instead of calculating
it. On ouput we should be getting hash from sk->txhash for connected
sockets.