Re: [PATCH v2 net-next] tcp: Fix CWV being too strict on thin streams

From
Neal Cardwell <ncardwell@google.com>
Date
2015-09-23 18:37:59
Reply to
Bendik Rønning Opstad, 2015-09-23
On Wed, Sep 23, 2015 at 12:49 PM, Bendik Rønning Opstad
[off-list ref] wrote:
Application limited streams such as thin streams, that transmit small
amounts of payload in relatively few packets per RTT, can be prevented
from growing the CWND when in congestion avoidance. This leads to
increased sojourn times for data segments in streams that often transmit
time-dependent data.

Currently, a connection is considered CWND limited only after having
successfully transmitted at least one packet with new data, while at the
same time failing to transmit some unsent data from the output queue
because the CWND is full. Applications that produce small amounts of
data may be left in a state where it is never considered to be CWND
limited, because all unsent data is successfully transmitted each time
an incoming ACK opens up for more data to be transmitted in the send
window.

Fix by always testing whether the CWND is fully used after successful
packet transmissions, such that a connection is considered CWND limited
whenever the CWND has been filled. This is the correct behavior as
specified in RFC2861 (section 3.1).

Cc: Andreas Petlund <redacted>
Cc: Carsten Griwodz <redacted>
Cc: Jonas Markussen <redacted>
Cc: Kenneth Klette Jonassen <redacted>
Cc: Mads Johannessen <redacted>
Signed-off-by: Bendik Rønning Opstad <redacted>
---
Acked-by: Neal Cardwell <ncardwell@google.com>
Tested-by: Neal Cardwell <ncardwell@google.com>

I ran all the Google packetdrill test cases with this patched in, and
all still pass.

I also re-ran the test I posted in the v1 thread (based on Eric's
test), and it still passes.

neal
Thread (5 messages) 5 messages, 4 authors, last reply 2015-09-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help