[RFC net-next 06/11] net: Replace calls to vrf_dev_get_rth
flat view
STALE4056d
SUPERSEDED
From: David Ahern <hidden>
Date: 2015-09-18 17:06:45
Subsystem:
networking [general], networking [ipv4/ipv6], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern, Ido Schimmel, Linus Torvalds
Status: Superseded by v3 (posted 2015-09-30). [go to v3]
Revision rfc (4 revisions archived).
Revisions (4)
Replace calls to vrf_dev_get_rth with l3mdev_get_rtable. The check on the flow flags is handled in the l3mdev operation. Signed-off-by: David Ahern <redacted> --- include/net/vrf.h | 22 ---------------------- net/ipv4/route.c | 9 ++++----- 2 files changed, 4 insertions(+), 27 deletions(-)
diff --git a/include/net/vrf.h b/include/net/vrf.h
index b05b96646e2a..5bba1535ba73 100644
--- a/include/net/vrf.h
+++ b/include/net/vrf.h@@ -32,26 +32,4 @@ struct net_vrf { u32 tb_id; }; - -#if IS_ENABLED(CONFIG_NET_VRF) -/* caller has already checked netif_is_l3_master(dev) */ -static inline struct rtable *vrf_dev_get_rth(const struct net_device *dev) -{ - struct rtable *rth = ERR_PTR(-ENETUNREACH); - struct net_vrf *vrf = netdev_priv(dev); - - if (vrf) { - rth = vrf->rth; - atomic_inc(&rth->dst.__refcnt); - } - return rth; -} - -#else -static inline struct rtable *vrf_dev_get_rth(const struct net_device *dev) -{ - return ERR_PTR(-ENETUNREACH); -} -#endif - #endif /* __LINUX_NET_VRF_H */
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 90cf915c36d9..af610bba3451 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c@@ -112,7 +112,6 @@ #endif #include <net/secure_seq.h> #include <net/ip_tunnels.h> -#include <net/vrf.h> #include <net/l3mdev.h> #define RT_FL_TOS(oldflp4) \
@@ -2127,10 +2126,10 @@ struct rtable *__ip_route_output_key(struct net *net, struct flowi4 *fl4) fl4->saddr = inet_select_addr(dev_out, 0, RT_SCOPE_HOST); } - if (netif_is_l3_master(dev_out) && - !(fl4->flowi4_flags & FLOWI_FLAG_VRFSRC)) { - rth = vrf_dev_get_rth(dev_out); - goto out; + if (netif_is_l3_master(dev_out)) { + rth = l3mdev_get_rtable(dev_out, fl4); + if (rth) + goto out; } }
--
1.9.1