Re: [PATCH net-next 4/5] qeth: add layer 2 RX/TX checksum offloading

From
David Miller <davem@davemloft.net>
Date
2015-09-17 23:24:08
Also in
linux-s390
Reply to
Ursula Braun, 2015-09-15
From: Ursula Braun <redacted>
Date: Tue, 15 Sep 2015 12:32:17 +0200
quoted hunk ↗ jump to hunk
+int qeth_send_setassparms(struct qeth_card *, struct qeth_cmd_buffer *, __u16,
+	long,
+	int (*reply_cb)(struct qeth_card *, struct qeth_reply *, unsigned long),
+	void *);
Function declarations and definitions that span multiple lines must begin
the second and subsequent lines precisely at the column right after the
openning parenthesis of the declaration/definition.

Indenting those lines just by a plain TAB character is not correct.
+static int qeth_setassparms_cb(struct qeth_card *card,
+			struct qeth_reply *reply, unsigned long data)
Likewise.
quoted hunk ↗ jump to hunk
+static struct qeth_cmd_buffer *qeth_get_setassparms_cmd(
+	struct qeth_card *card, enum qeth_ipa_funcs ipa_func, __u16 cmd_code,
+	__u16 len, enum qeth_prot_versions prot)
Likewise.
quoted hunk ↗ jump to hunk
+int qeth_send_setassparms(struct qeth_card *card,
+	struct qeth_cmd_buffer *iob, __u16 len, long data,
+	int (*reply_cb)(struct qeth_card *, struct qeth_reply *,
+		unsigned long),
+	void *reply_param)
Likewise.

And so on and so forth.
Thread (7 messages) 7 messages, 2 authors, last reply 2015-09-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help