Thread (3 messages) 3 messages, 3 authors, 2015-09-15

Re: [PATCH net v2] openvswitch: Fix mask generation for nested attributes.

flat view

From: Pravin Shelar <hidden>
Date: 2015-09-13 00:04:36

On Fri, Sep 11, 2015 at 6:38 PM, Jesse Gross [off-list ref] wrote:
Masks were added to OVS flows in a way that was backwards compatible
with userspace programs that did not generate masks. As a result, it is
possible that we may receive flows that do not have a mask and we need
to synthesize one.

Generating a mask requires iterating over attributes and descending into
nested attributes. For each level we need to know the size to generate the
correct mask. We do this with a linked table of attribute types.

Although the logic to handle these nested attributes was there in concept,
there are a number of bugs in practice. Examples include incomplete links
between tables, variable length attributes being treated as nested and
missing sanity checks.

Signed-off-by: Jesse Gross <redacted>
Thanks for the fix.
Acked-by: Pravin B Shelar <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help