Re: [PATCH net-next 7/8] net: thunderx: Support for upto 96 queues for a VF
From: David Miller <davem@davemloft.net>
Date: 2015-08-29 05:10:53
Also in:
linux-arm-kernel, lkml
From: David Miller <davem@davemloft.net>
Date: 2015-08-29 05:10:53
Also in:
linux-arm-kernel, lkml
From: Alexey Klimov <redacted> Date: Sat, 29 Aug 2015 04:45:03 +0300
quoted
@@ -717,9 +833,24 @@ static void nic_unregister_interrupts(struct nicpf *nic) nic_disable_msix(nic); } +static int nic_num_sqs_en(struct nicpf *nic, int vf_en) +{ + int pos = 0, sqs_per_vf = MAX_SQS_PER_VF_SINGLE_NODE;Please check if you really need to initialize 'pos' by zero here.
Please do _NOT_ quote hundreds of lines of code only to give feedback on one particular hunk. Quote _ONLY_ the exact context required, nothing more. Everyone has to scroll through all of this unrelated crap you quoted, and that makes more work for everyone. Think particularly of _ME_ who has to be aware of what's going on in every discussion thread for every patch that gets posted to this list.