Re: [v2] net: phy: fixed: propagate fixed link values to struct
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2015-08-26 18:50:36
Also in:
lkml
On 26/08/15 07:58, Madalin Bucur wrote:
The fixed link values parsed from the device tree are stored in the struct fixed_phy member status. The struct phy_device members speed, duplex were not updated.
Arguably you need to start the PHY state machine for this to work properly, but this looks fine to me.
Signed-off-by: Madalin Bucur <redacted>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
quoted hunk ↗ jump to hunk
--- v2: always setting phy->link, thanks Stas drivers/net/phy/fixed_phy.c | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index 479b93f..99d9bc1 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c@@ -292,6 +292,15 @@ struct phy_device *fixed_phy_register(unsigned int irq, return ERR_PTR(-EINVAL); } + /* propagate the fixed link values to struct phy_device */ + phy->link = status->link; + if (status->link) { + phy->speed = status->speed; + phy->duplex = status->duplex; + phy->pause = status->pause; + phy->asym_pause = status->asym_pause; + } + of_node_get(np); phy->dev.of_node = np;
-- Florian