Re: [PATCH v2 4/4] Added getsynctime64() callback

On Thu, Aug 13, 2015 at 09:10:36PM +0000, Hall, Christopher S wrote:

quoted

quoted

+	if (!cpu_has_art)
+		return -EOPNOTSUPP;

Perform this check before registration, setting .getsynctime64
accordingly.

The problem here is that ART initialization doesn't happen until we
install TSC as a clocksource.  This design is per Thomas'
suggestion.  That occurs after the driver is loaded (as a module).

So that 'cpu_has_art' actually means 'cpu_has_art_and_has_been_initialized'?

In any case, returning EOPNOTSUPP early on, but OK later seems mean to
me.  If the clocks aren't ready yet, the error should be EBUSY so that
user space knows it can try again.

Thanks,
Richard