Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad

On Tue, Aug 11, 2015 at 07:56:06PM +0100, Sergei Shtylyov wrote:

Hello.

On 08/11/2015 05:35 PM, Liviu Dudau wrote:

quoted

On some embedded systems the EEPROM does not contain a valid MAC address.
In that case it is better to fallback to a generated mac address and
let init scripts fix the value later.

quoted

Reported-by: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
[Changed handcoded setup to use eth_hw_addr_random() instead]
Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
---
I have tested this on my Juno platform and I can successfully do an nfsroot boot.

quoted

Best regards,
Liviu

quoted

  drivers/net/ethernet/marvell/sky2.c | 7 +++++++
  1 file changed, 7 insertions(+)

quoted

diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index d9f4498..c309879 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c

@@ -4819,6 +4819,13 @@ static struct net_device *sky2_init_netdev(struct sky2_hw *hw, unsigned port,
  		memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port * 8,
  			      ETH_ALEN);

+	/* if the address is invalid, use a random value */
+	if (!is_valid_ether_addr(dev->dev_addr)) {
+		netdev_warn(dev,
+			"Invalid MAC address, defaulting to random\n");

    Please start the continuation line right under 'dev' on the borken up line.

OK, I will make the changes for v3.

quoted

+		eth_hw_addr_random(dev);
+	}
+
  	return dev;
  }

MBR, Sergei

Thanks for reviewing this!

Best regards,
Liviu

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯