Thread (5 messages) 5 messages, 3 authors, 2015-08-07

Re: [PATCH net V2] virtio-net: drop NETIF_F_FRAGLIST

flat view

From: David Miller <davem@davemloft.net>
Date: 2015-08-06 22:49:16
Also in: lkml, virtualization

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 6 Aug 2015 16:13:11 +0300
On Wed, Aug 05, 2015 at 10:34:04AM +0800, Jason Wang wrote:
quoted
virtio declares support for NETIF_F_FRAGLIST, but assumes
that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
always true with a fraglist.

A longer fraglist in the skb will make the call to skb_to_sgvec overflow
the sg array, leading to memory corruption.

Drop NETIF_F_FRAGLIST so we only get what we can handle.

Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <redacted>
I noticed only now that this didn't Cc Dave, so of course it's
not applied.
CC:'ing me isn't the requirement. CC:'ing netdev is, which he
did.  If you check patchwork, it's there in the queue.

I'm just behind and heavily backlogged because I've been working
on other things.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help