Thread (2 messages) 2 messages, 2 authors, 2015-08-31

Re: ss format bug

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2015-08-31 23:23:05

On Wed, 26 Aug 2015 11:59:17 -0400
Mike Saal [off-list ref] wrote:
Hi:

I found a formatting bug in the 4.1.1 ss command. The following line was 
incorrectly output due to passing a negative length to printf() when 
displaying the local address. In this instance hostapd does a "bind to 
device" on cdreth0 and then does a udp "in address any" port 67 bind. 
Please note the whitespace between the '*' and ' %cdreth0:67'

    'udp UNCONN 0 0 ** %cdreth0:67* *:* users:(("hostapd",pid=19241,fd=5))'

Attached is my patch for the bug fix, it might be prudent to add more 
guard code looking for negative length format codes.

Sincerely, Mike

I think the root cause of this is actually down in the main program
where it is computing addr_width. It is not accounting for the size correctly,
or maybe your case just occurs if screen is too narrow to fit the full width.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help