Re: [net-next PATCH 3/4] net: sched: register noqueue qdisc
From: Sergei Shtylyov <hidden>
Date: 2015-08-29 20:04:48
Hello. On 8/27/2015 10:21 PM, Phil Sutter wrote:
This way users can attach noqueue just like any other qdisc using tc without having to mess with tx_queue_len first. Signed-off-by: Phil Sutter <phil@nwl.cc> --- include/net/sch_generic.h | 1 + net/sched/sch_api.c | 1 + net/sched/sch_generic.c | 12 +++++++++++- 3 files changed, 13 insertions(+), 1 deletion(-)
[...]
quoted hunk ↗ jump to hunk
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index f501b74..d5c7c0d 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c@@ -416,9 +416,19 @@ struct Qdisc noop_qdisc = { }; EXPORT_SYMBOL(noop_qdisc); -static struct Qdisc_ops noqueue_qdisc_ops __read_mostly = { +static int noqueue_init(struct Qdisc *qdisc, struct nlattr *opt) +{ + /* register_qdisc() assigns a default of noop_enqueue if unset, + * but __dev_queue_xmit() treats noqueue only as such + * if this is NULL - so clear it here. */
The multi-line comments in the networking code should follow this style:
/* bla
* bla
*/
[...]
MBR, Sergei