Re: [patch net-next v2 2/3] mlxsw: adjust transmit fail log message level in __mlxsw_emad_transmit
From: Joe Perches <joe@perches.com>
Date: 2015-08-27 17:56:24
On Thu, 2015-08-27 at 17:59 +0200, Jiri Pirko wrote:
When transmit fails, it is an error, not a warning.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
[]
quoted hunk ↗ jump to hunk
@@ -376,8 +376,8 @@ static int __mlxsw_emad_transmit(struct mlxsw_core *mlxsw_core, err = mlxsw_core_skb_transmit(mlxsw_core->driver_priv, skb, tx_info); if (err) { - dev_warn(mlxsw_core->bus_info->dev, "Failed to transmit EMAD (tid=%llx)\n", - mlxsw_core->emad.tid); + dev_err(mlxsw_core->bus_info->dev, "Failed to transmit EMAD (tid=%llx)\n", + mlxsw_core->emad.tid);
dev_err_ratelimited?