Re: [PATCH v3 net-next 1/8] geneve: Initialize ethernet address in device setup.
flat view
From: John W. Linville <hidden>
Date: 2015-08-26 20:45:14
On Mon, Aug 24, 2015 at 10:43:08AM -0700, Pravin B Shelar wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Pravin B Shelar <redacted> Reviewed-by: Jesse Gross <redacted> Acked-by: Thomas Graf <tgraf@suug.ch> --- drivers/net/geneve.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 897e1a3..95e9da0 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c@@ -297,6 +297,7 @@ static void geneve_setup(struct net_device *dev) netif_keep_dst(dev); dev->priv_flags |= IFF_LIVE_ADDR_CHANGE | IFF_NO_QUEUE; + eth_hw_addr_random(dev); } static const struct nla_policy geneve_policy[IFLA_GENEVE_MAX + 1] = {@@ -364,9 +365,6 @@ static int geneve_newlink(struct net *net, struct net_device *dev, return -EBUSY; } - if (tb[IFLA_ADDRESS] == NULL) - eth_hw_addr_random(dev); - err = register_netdevice(dev); if (err) return err;
Acked-by: John W. Linville <redacted> -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.