Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi
From: Eric Dumazet <hidden>
Date: 2015-08-19 16:08:37
Also in:
linux-wireless
From: Eric Dumazet <hidden>
Date: 2015-08-19 16:08:37
Also in:
linux-wireless
On Wed, 2015-08-19 at 15:07 +0000, Grumbach, Emmanuel wrote:
I'll look at it. I was almost starting to implement that but then I thought with another (good?) reason to use LSO. LSO gives me the guarantee that the packet is directed to one peer, which might not be the case with xmit_more since we have one Qdisc for several clients in case we are in AP mode. Building an A-MSDU for several clients is not possible, at least not for several client in the L2 (different MAC addresses). LSO avoids this problem completely.
Then, simply calling skb_gso_segment() from the driver might be enough,
and less work for you.
This would even support TSO on IPv6
segs = skb_gso_segment(skb, tp->dev->features &
~(NETIF_F_TSO | NETIF_F_TSO6));