Thread (33 messages) flat view 33 messages, 4 authors, 2015-08-20

Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

From: Jesse Gross <hidden>
Date: 2015-08-19 01:07:49

On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 546494d..cb2d874 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
+static int geneve_configure(struct net *net, struct net_device *dev,
+                           __be32 rem_addr, __u32 vni, __u8 ttl, __u8 tos,
+                           __u16 dst_port, bool metadata)
[...]
-       if (!data[IFLA_GENEVE_ID] || !data[IFLA_GENEVE_REMOTE])
-               return -EINVAL;
+       if (metadata && rtnl_dereference(gn->collect_md_tun))
+               return -EEXIST;
This will allow you to configure a collect_md_tun devices and normal
devices on top of each other, even though the latter will never get
hit in that situation.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help