RE: [PATCH 2/4] batman-adv: fix kernel crash due to missing NULL checks

From: Antonio Quartulli

Sent: 11 August 2015 17:43
On 05/08/15 15:15, David Laight wrote:

quoted

So is this test just hiding anoter bug somewhere??

Hi David and thanks for your feedback.

The point is that we got several bug reports of kernel crashes due to
NULL pointer deferences in these lines and after having debugged this
problem for quite a while we preferred to move on and propose this patch.

That is what I thought.

Still, I am personally debugging this part of the code to understand if
we really have something wrong or if this NULL pointer is something we
should expect (and therefore check).

For the time being we think this patch is better than having horrible
kernel crashes, but I hope to come to a definitive conclusion soon.

If you don't know why you are seeing the NULL pointer then you are
just papering over some cracks and it is likely that something
is really badly wrong somewhere (ie missing locking).
This could easily mean that there are some much harder to find
bugs lurking there.

	David