Thread (12 messages) flat view 12 messages, 2 authors, 2015-08-19
STALE4006d

[PATCH 10/10] ss: fixed free on local array for valid json output

From: Matthias Tafelmeier <hidden>
Date: 2015-08-10 18:53:03
Subsystem: the rest · Maintainer: Linus Torvalds

Minor fix to enable json output. Freeing of automatic char array name
which will get freed after function stack cleanup. Another one after
tcp_stats_fmt for freeing automatic tcpstats struct instance.

Signed-off-by: Matthias Tafelmeier <redacted>
Suggested-by: Hagen Paul Pfeifer <redacted>
---
 misc/ss.c | 6 ------
 1 file changed, 6 deletions(-)
diff --git a/misc/ss.c b/misc/ss.c
index 5eba08d..722253a 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -1664,10 +1664,6 @@ static void tcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r,
 		s.segs_out = info->tcpi_segs_out;
 		s.segs_in = info->tcpi_segs_in;
 		tcp_stats_fmt(&s);
-		if (s.dctcp)
-			free(s.dctcp);
-		if (s.cong_alg)
-			free(s.cong_alg);
 	}
 }
 
@@ -2366,8 +2362,6 @@ if (show_mem) {
 	if (json_output)
 		printf("}\n");
 
-	if (name)
-		free(name);
 	return 0;
 }
 
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help