Thread (8 messages) 8 messages, 3 authors, 2015-08-03

Re: [patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

From: Joe Stringer <hidden>
Date: 2015-08-03 18:29:14
Also in: kernel-janitors, netfilter-devel

On 30 July 2015 at 04:57, Pablo Neira Ayuso [off-list ref] wrote:
quoted hunk ↗ jump to hunk
On Tue, Jul 28, 2015 at 01:42:28AM +0300, Dan Carpenter wrote:
quoted
We recently changed this from nf_conntrack_alloc() to nf_ct_tmpl_alloc()
so the error handling needs to changed to check for NULL instead of
IS_ERR().

Fixes: 0838aa7fcfcd ('netfilter: fix netns dependencies with conntrack templates')
Signed-off-by: Dan Carpenter <redacted>
Applied, thanks.

I have also appended this chunk, since synproxy is also affected:
--- a/net/netfilter/nf_synproxy_core.c
+++ b/net/netfilter/nf_synproxy_core.c
@@ -353,7 +353,7 @@ static int __net_init synproxy_net_init(struct net *net)
        int err = -ENOMEM;

        ct = nf_ct_tmpl_alloc(net, 0, GFP_KERNEL);
-       if (IS_ERR(ct)) {
+       if (!ct) {
                err = PTR_ERR(ct);
                goto err1;
        }
Does PTR_ERR() implicitly interpret NULL as -ENOMEM? Seems like the
fix applied here is a little different from the xt_CT fix.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help