Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

On 31 July 2015 at 08:26, Hannes Frederic Sowa [off-list ref] wrote:

On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote:

quoted

+static void do_output(struct datapath *dp, struct sk_buff *skb, int
out_port,
+                   struct sw_flow_key *key)
 {
      struct vport *vport = ovs_vport_rcu(dp, out_port);

-     if (likely(vport))
-             ovs_vport_send(vport, skb);
-     else
+     if (likely(vport)) {
+             unsigned int mru = OVS_CB(skb)->mru;
+             struct dst_entry *orig_dst = dst_clone(skb_dst(skb));

I think you forgot to remove this?

You're right that it's incorrect, however we do still need to ensure
that the original skb's reference to the orig_dst is released. I'll
tidy this up for v2.