Re: [PATCH] ipsec:Fix error handling in the function xfrm6_get_addr
flat view
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-07-31 00:00:56
Also in:
lkml
On Thu, Jul 30, 2015 at 12:20:40PM -0400, Nicholas Krause wrote:
quoted hunk
diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index ed0583c..f60c670 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6/xfrm6_policy.c@@ -61,7 +61,9 @@ static int xfrm6_get_saddr(struct net *net, return -EHOSTUNREACH; dev = ip6_dst_idev(dst)->dev; - ipv6_dev_get_saddr(dev_net(dev), dev, &daddr->in6, 0, &saddr->in6); + if (ipv6_dev_get_saddr(dev_net(dev), dev, &daddr->in6, 0, &saddr->in6)) + return -EADDRNOTAVAIL; + dst_release(dst);
You're leaking dst. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt