Thread (21 messages) 21 messages, 3 authors, 2015-07-30

RE: [PATCH net 1/2] r8152: add pre_reset and post_reset

From: Hayes Wang <hidden>
Date: 2015-07-28 10:29:22
Also in: lkml

Oliver Neukum [mailto:oneukum@suse.com]
Sent: Tuesday, July 28, 2015 4:53 PM
[...]
quoted
+		return 0;
+
+	netdev = tp->netdev;
+	if (!netif_running(netdev))
+		return 0;
+
+	ret = usb_autopm_get_interface(intf);
+	if (ret < 0)
+		return ret;
What sense does this make?
[...]
quoted
+		return 0;
+
+	netdev = tp->netdev;
+	if (!netif_running(netdev))
+		return 0;
+
+	ret = usb_autopm_get_interface(intf);
The device will be awake.
I don't sure if the device would be in runtimesuspend, so I wake it up by myself.
I think you mean I don't have to do this. I would remove them and resend the
patch. Thanks.

Best Regards,
Hayes

�{.n�+�������+%��lzwm��b�맲��r��zX���n)���w*jg���
�����ݢj.�۰\��M��gj��a����' ��ޢ�
���j:+v���w�j�m��������zZ+�����ݢj"��!�i
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help