Re: [PATCH] cgroup: net_cls: fix false-positive "suspicious RCU usage"
From: David Miller <hidden>
Date: 2015-07-22 05:29:01
Also in:
cgroups, lkml
From: Konstantin Khlebnikov <redacted> Date: Tue, 21 Jul 2015 19:46:29 +0300
quoted hunk ↗ jump to hunk
@@ -23,7 +23,8 @@ static inline struct cgroup_cls_state *css_cls_state(struct cgroup_subsys_state struct cgroup_cls_state *task_cls_state(struct task_struct *p) { - return css_cls_state(task_css(p, net_cls_cgrp_id)); + return css_cls_state(task_css_check(p, net_cls_cgrp_id, + rcu_read_lock_bh_held()));
You've made a serious mess of the indentation here. First of all, you've changed the correct plain "TAB" before the 'return' line into a TAB and two SPACE characters. Secondly, the second line needs to be precisely indented to the exact column following the openning parenthesis of the task_css_check() call on the previous line.